From 95dbf1deb361e6b4fa71836b7b437bdb60a7f853 Mon Sep 17 00:00:00 2001
From: undefined <i@undefined.moe>
Date: Thu, 27 Apr 2023 02:14:05 +0800
Subject: [PATCH] core: only add cache-control header if signLink success

---
 packages/hydrooj/src/handler/misc.ts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/hydrooj/src/handler/misc.ts b/packages/hydrooj/src/handler/misc.ts
index 9d61e64d..ee4d5cda 100644
--- a/packages/hydrooj/src/handler/misc.ts
+++ b/packages/hydrooj/src/handler/misc.ts
@@ -84,7 +84,6 @@ export class FSDownloadHandler extends Handler {
     @param('filename', Types.Filename)
     @param('noDisposition', Types.Boolean)
     async get(domainId: string, uid: number, filename: string, noDisposition = false) {
-        this.response.addHeader('Cache-Control', 'public');
         const target = `user/${uid}/${filename}`;
         const file = await storage.getMeta(target);
         await oplog.log(this, 'download.file.user', {
@@ -95,6 +94,7 @@ export class FSDownloadHandler extends Handler {
             this.response.redirect = await storage.signDownloadLink(
                 target, noDisposition ? undefined : filename, false, 'user',
             );
+            this.response.addHeader('Cache-Control', 'public');
         } catch (e) {
             if (e.message.includes('Invalid path')) throw new NotFoundError(filename);
             throw e;